Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] GA 로깅 모듈 분리 및 버스 로깅 #520

Merged
merged 8 commits into from
Jan 6, 2025
Merged

[Feature] GA 로깅 모듈 분리 및 버스 로깅 #520

merged 8 commits into from
Jan 6, 2025

Conversation

ThirFir
Copy link
Contributor

@ThirFir ThirFir commented Dec 28, 2024

  • EventLogger를 core:analytics 모듈로 분리했습니다.
  • 및 버스 로깅 추가

@ThirFir ThirFir self-assigned this Dec 28, 2024
@ThirFir ThirFir requested a review from a team as a code owner December 28, 2024 06:32
Jokwanhee
Jokwanhee approved these changes Jan 5, 2025
View reviewed changes
Copy link
Collaborator

@Jokwanhee Jokwanhee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했어요! LGTM👍

nodobi
nodobi approved these changes Jan 5, 2025
View reviewed changes
Copy link
Contributor

@nodobi nodobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

모듈화 깔끔하네요!! 고생하셨습니다 😊

@ThirFir ThirFir merged commit bb2330d into develop Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jokwanhee Jokwanhee Jokwanhee approved these changes

@nodobi nodobi nodobi approved these changes

Assignees

@ThirFir ThirFir

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThirFir @nodobi @Jokwanhee